Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Vertex Search and Conversation Chat Engine #6918

Conversation

modular-magician
Copy link
Collaborator

This PR adds Vertex Search and Conversation Chat Engine

`google_discovery_engine_chat_engine`

This provider has the following field set to default and hard coded to enforce type specific schema validation
solutionType="SOLUTION_TYPE_CHAT"

Derived from GoogleCloudPlatform/magic-modules#9834

* merge change

* add chat_engine

* update chat engine to allow creating new agent only

* fix asyc, update field updatability

* update file name

* sync product.yaml changes

* sync changes

* discard product.yaml change

* update filename case

* add acc test

* fix indentation

* fix indentation

* format

* update API to ga and support location parameter

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* minor changes

* updating fields

* add name output only field, add custom encoder to hardcode solutionType

* update documentation

* update doc

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* update industryVertical to enum

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Update mmv1/templates/terraform/examples/discoveryengine_chat_engine_basic.tf.erb

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Update mmv1/templates/terraform/examples/discoveryengine_chat_engine_basic.tf.erb

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* remove agent creation location field, set default industryVertical

* update test

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* update test

* update example and test

* remove empty line in test

* Apply suggestions from code review

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* add vars for TF examples

* Update mmv1/products/discoveryengine/ChatEngine.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Update mmv1/third_party/terraform/services/discoveryengine/resource_discovery_engine_chat_engine_test.go

remove duplicate test

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Update mmv1/third_party/terraform/services/discoveryengine/resource_discovery_engine_chat_engine_test.go

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* update test names

* format code

* remove redundant test

* Apply suggestions from code review

---------

Co-authored-by: Ray Xu <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

[upstream:a0178b8b4818ac1ab08774fdb81c5ad8bed80b48]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 4564974 into hashicorp:main Jan 31, 2024
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-a0178b8b4818ac1ab08774fdb81c5ad8bed80b48 branch November 16, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant