Remove use of google_kms_crypto_key_iam_binding resources in acceptance tests to reduce test failures related to missing permissions
#6737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ance tests to reduce test failures related to missing permissions (#9590) * Replace use of `google_kms_crypto_key_iam_binding` with `_member` equivalent * Replace use of `google_kms_crypto_key_iam_binding` with `_member` equivalent in examples files * Split `google_kms_crypto_key_iam_binding` with 2 members into two `_member` IAM resources in example file * Replace `google_kms_crypto_key_iam_binding` with 5 members into `_member` IAM resources created via for_each loop When this example is used to generate a test the crypto key used is a bootstrapped resource. By using an authoritative `_binding` IAM resource we allow conflict between tests using the same bootstrapped cypto key * Fix mistyped argument name * Remove use of for_each in acceptance test, create separate example files for test vs docs * SKip `TestAccCloudfunctions2function_cloudfunctions2CmekExample` in VCR * Skip `TestAccDataprocMetastoreService_dataprocMetastoreServiceCmekTestExample` in VCR [upstream:9e772a85d6c113ae38b6e5439d7ae72380481bec] Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-9e772a85d6c113ae38b6e5439d7ae72380481bec
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to hashicorp/terraform-provider-google#16687
We have a group of bootstrapped KMS keys in the test projects that can be used by acceptance tests but aren't created/deleted by tests.
Because these resources are reused by tests there is a chance that tests will conflict with each other when editing the IAM permissions on the resource.
In this PR I remove unnecessary use of
google_kms_crypto_key_iam_bindingso it's easier to identify instances when a test is affecting bootstrapped resources' IAM policies authoritatively.An example I've identified that affects a bootstrapped KMS key is generated from the
mmv1/templates/terraform/examples/cloudfunctions2_cmek.tf.erbfile to make the generated testTestAccCloudfunctions2function_cloudfunctions2CmekExampleRelease Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9590