Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stateful ips ga #6453

Conversation

modular-magician
Copy link
Collaborator

This promotes Stateful IPs functionalities to GA . Modifies (Region)InstanceGroupManagers and (Region)PerInstanceConfigs.
fixes #10908

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
While running the tests one of them fails (TestAccInstanceGroupManager_waitForStatus), but it does not use the new field and it simply times out.
Read Write release notes before writing my release note below.
Release Note Template for Downstream PRs (will be copied)

compute: promoted `internal_ip` and `external_ip` fields in resources `google_compute_instance_group_manager` and `google_compute_region_instance_group_manager` to GA
compute: promoted `internal_ip` and `external_ip` fields in resources `google_compute_per_instance_config` and `google_compute_region_per_instance_config` to GA

Derived from GoogleCloudPlatform/magic-modules#9115

* Promote Stateful IPs in PerInstance Configs and (Regional)InstanceGroupManagers to GA

* modify google go libraries to use new version

* Add changes to go.sum

* modify go.mod further

* modified go.sum after running go mod tidy

* fix go.mod.erb

* tabularize go.mod.erb

---------

Co-authored-by: Adam Skubis <[email protected]>
[upstream:865e5c5a6f61304bded9112b0a8a3b6037afba1d]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit d5403b6 into hashicorp:main Oct 5, 2023
@modular-magician modular-magician deleted the downstream-pr-865e5c5a6f61304bded9112b0a8a3b6037afba1d branch November 16, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant