Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecretManager Secret: Prevent recreation for "automatic" to "auto" #6325

Conversation

modular-magician
Copy link
Collaborator

fixes hashicorp/terraform-provider-google#15885

Creates a custom diff that prevents immutability when following upgrade guide steps for replication.auto
Things to note:

  • Does not prevent the reverse: removing "auto" and adding "automatic"
  • Updating to an empty auto {} still calls the API with a trivial PATCH request.

Tested manually with local provider.

Release Note Template for Downstream PRs (will be copied)

secretmanager: fixed an issue in `google_secretmanager_secret` where replacing `replication.automatic` with `replication.auto` would destroy and recreate the resource

Derived from GoogleCloudPlatform/magic-modules#9030

@modular-magician modular-magician merged commit 68961ac into hashicorp:main Sep 20, 2023
4 checks passed
trodge pushed a commit that referenced this pull request Sep 21, 2023
@modular-magician modular-magician deleted the downstream-pr-a12e81cea487686855f430a7874180872fa187f5 branch November 16, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant