Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding backupdr product with managementServer resource #6054

Conversation

modular-magician
Copy link
Collaborator

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_backup_dr_management_server`

Derived from GoogleCloudPlatform/magic-modules#8612

* Add Backupdr with Management Server resource

* Fixing lint issue

* Fixing Variable name

* FIxing values of type and peering mode

* Fixing description and example

* Adding type and Peering_mode to coverage

* Changing release version of provider to only beta

* Changing variable name

* Fixing Acceptance test and trademark

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 1da32cc into hashicorp:main Aug 11, 2023
@modular-magician modular-magician deleted the downstream-pr-ef6b681b9a2ff8d0ec32dd6e0d726b1a16b60de6 branch November 16, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant