Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CHANGELOG for v4.63.0 #5526

Merged
merged 9 commits into from
Apr 24, 2023
Merged

Add CHANGELOG for v4.63.0 #5526

merged 9 commits into from
Apr 24, 2023

Conversation

SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented Apr 20, 2023 •
edited
Loading

TODO:

  • Edit changelog to meet style guide
  • add cherry pick to release branch
  • add cherry pick to changelog - see comment for why this isn't needed
  • remove 4.62.1 cherrypick from changelog

@github-actions
Copy link

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

@SarahFrench
Copy link
Member Author

Cherry pick commit added to release branch: 6d61452

Yet to update CHANGELOG

@SarahFrench
Updated CHANGELOG to match style guide
24d6b53 
Removed reverted PRs and non user facing changes
@github-actions github-actions bot added size/xs and removed size/s labels Apr 21, 2023
@SarahFrench
Copy link
Member Author

SarahFrench commented Apr 21, 2023 •
edited
Loading

This release includes a cherrypick : GoogleCloudPlatform/magic-modules#7762

It fixes the commit for: New Resource: google_access_context_manager_ingress_policy (#5474)

Because of this, it doesn't need an entry in the CHANGELOG. But it will need to be removed in the next release's CHANGELOG.

@SarahFrench SarahFrench marked this pull request as ready for review April 21, 2023 14:08
@github-actions github-actions bot requested a review from c2thorn April 21, 2023 14:08
@SarahFrench SarahFrench requested a review from c2thorn April 21, 2023 19:04
@SarahFrench
Copy link
Member Author

This PR needs fixes - marking as draft until that's done

@SarahFrench SarahFrench marked this pull request as draft April 21, 2023 19:04
@SarahFrench
Consolidate alloydb notes into single NOTE entry and remove equivalen…
48e1671 
…t BUG FIXES entries, fix resource name, update compute bug fix note
@SarahFrench
Fix previous commit
dfbf88c
@SarahFrench SarahFrench changed the title Add CHANGELOG diff (unedited) for v4.63.0 Add CHANGELOG for v4.63.0 Apr 21, 2023
@SarahFrench
Copy link
Member Author

Updated this PR to match hashicorp/terraform-provider-google#14382

@SarahFrench SarahFrench marked this pull request as ready for review April 21, 2023 19:17
@github-actions github-actions bot requested a review from ScottSuarez April 21, 2023 19:18
@SarahFrench SarahFrench removed the request for review from ScottSuarez April 21, 2023 19:56
melinath
melinath reviewed Apr 24, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@melinath melinath merged commit 7239035 into release-4.63.0 Apr 24, 2023
@melinath melinath deleted the SarahFrench-patch-1 branch April 24, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melinath melinath melinath approved these changes

@c2thorn c2thorn Awaiting requested review from c2thorn

Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SarahFrench @melinath @c2thorn