Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestAccApigeeInstance_apigeeInstanceIpRangeTestExample to use reserved ips #5212

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#11071

The ip_range for an Apigee instance can be specified explicitly if the user needs certain IPs to be used. Previously, this test was using a hard-coded IP range that was not available. The fix was to instead provide it with an IP range that was already reserved by the networking connection (and in this case, it simply uses the beginning of that range).

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#7301

@modular-magician modular-magician merged commit 86cfbe6 into hashicorp:main Feb 15, 2023
@modular-magician modular-magician deleted the downstream-pr-2496c640d789e617ddb007c460d9ac428286d093 branch November 16, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccApigeeInstance_apigeeInstanceIpRangeTestExample
1 participant