Append a more explanatory error message for Compute Operation errors. #4602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hashicorp#6403) * Prefer the Message field on LocalizedMessage to that of the top level Message. * Also update go.sum * Write full Operation error including ErrorInfo Do not just write the Operation error's LocalizedMessage.Message, but alos maintain the top level Message in the `Error() string` return value and also serialize the ErrorInfo that might exists in the error response as json to the returned error string. * Don't need to write an additional new line * Need encoding/json for ga too because of ErrorInfo Since we're serializing ErrorInfo to json and appending to a buffer for the ComputeOperationError message, we need encoding/json in ga too. * Do not append ErrorInfo as JSON Append LocalizedMessage.Message to Error.Message, but do not serailize an ErrorInfo, if one were to exist, as JSON to the io.Writer. * Need to import io for io.StringWriter Signed-off-by: Modular Magician <[email protected]>
modular-magician
deleted the
downstream-pr-7f1486685fefd29bb51ba20b983f53a864fd016d
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Append
LocalizedMessage.Messageto theComputeOperationErrortop-level Message as the string return value fromError()on the same,ComputeOpearationError.If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#6403