Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ExactlyOneOf for "content" and "source" #4292

Conversation

modular-magician
Copy link
Collaborator

Use ExactlyOneOf for content and source within google_storage_bucket_object so that if either are missing it fails at plan-time instead of apply time.

Also hi friends, I got bitten by this today, hope you're all doing well 🙂

I just did this quickly through the GitHub UI so I haven't done most of the checklist items; let me know if you need me to for a simple change like this.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

storage: not specifying `content` or `source` for `google_storage_bucket_object` now fails at plan-time instead of apply-time.

Derived from GoogleCloudPlatform/magic-modules#6009

* Use ExactlyOneOf for "content" and "source"

* gofmt

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit c063c42 into hashicorp:main May 7, 2022
@modular-magician modular-magician deleted the downstream-pr-a8da09d3cfdac5c611035db03912de88ad2666c5 branch November 16, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant