Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rate limiting options values #4049

Conversation

modular-magician
Copy link
Collaborator

Followup to hashicorp/terraform-provider-google#10020

Seems like some of the values were from the EAP/alpha API, but got renamed going to beta (I can see them in internal protos). I didn't catch it in the initial review, "threshold" and "throttle" looked pretty similar as one of four options.

Pulled the text directly from c.g.c. For the ones w/ a well-formatted entry there I removed the list in the inline Description, but for the one where it isn't I used the raw string.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: corrected an issue in `google_compute_security_policy` where only alpha values for certain enums were accepted

Derived from GoogleCloudPlatform/magic-modules#5691

@modular-magician modular-magician merged commit 9713e9f into hashicorp:master Feb 11, 2022
@modular-magician modular-magician deleted the downstream-pr-63df725b4cdf48df11dbd32fe7357065ed4e614b branch November 16, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant