Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spot VM support to GKE Node Pools #3833

Closed
wants to merge 1 commit into from

Conversation

sepich
Copy link

@sepich sepich commented Nov 8, 2021

GKE Node Pools now support Spot VMs (not to be confused with Preemptible VMs):
https://cloud.google.com/kubernetes-engine/docs/concepts/spot-vms
This is not supported in web UI yet, but gcloud cli have it:
https://cloud.google.com/kubernetes-engine/docs/how-to/spot-vms#create_a_node_pool_with_enabled
API field spot: https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1beta1/NodeConfig
(Also, pulumi with google_native provider already have the support)

@nat-henderson
Copy link
Contributor

This looks great - thank you for the change.

As it happens, this file is code generated - would you mind copying your change to the generator file, here:
https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/third_party/terraform/utils/node_config.go.erb

Thanks for your contribution!

If you like, we'll merge this PR when that goes in, so your contribution is counted against both repos - if that's not important to you, you can close this one when you open that one.

@sepich
Copy link
Author

sepich commented Nov 11, 2021

Sorry, I misunderstood this in a first place
GoogleCloudPlatform/magic-modules#5443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants