Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disk interface, tests #3611

Conversation

modular-magician
Copy link
Collaborator

Removes disk and region disk interface field as it is not useful and will be removed in the future.

Resolves: hashicorp/terraform-provider-google#10006
Resolves: hashicorp/terraform-provider-google#9993

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: deprecated `interface` field on `google_compute_disk` and `google_compute_region_disk` (beta only)

Derived from GoogleCloudPlatform/magic-modules#5185

* Remove disk interface tests

* Remove region disk test also

* Fix api compile

* Add DSF to always suppress diff, readd default

* Remove unused method from GA

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit a0243ac into hashicorp:master Sep 10, 2021
slevenick pushed a commit that referenced this pull request Sep 10, 2021
* Remove disk interface tests

* Remove region disk test also

* Fix api compile

* Add DSF to always suppress diff, readd default

* Remove unused method from GA

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician deleted the downstream-pr-a97a77269bcd1651faad7ab327350cf478f7d219 branch November 16, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant