Add rate limit options to google_compute_security_policy
#3596
Conversation
There was a problem hiding this comment.
Hi @anovis ! Thank you for your contribution and sorry for the delay in review! The majority of our PRs are open in our upstream repo where they are automatically assigned reviewers, this was mistakenly overlooked. I left one comment, feel free to make those changes in the upstream file and it will make it easier for us to run tests and review!
| @@ -311,6 +397,9 @@ func resourceComputeSecurityPolicyRead(d *schema.ResourceData, meta interface{}) | |||
| if err := d.Set("adaptive_protection_config", flattenSecurityPolicyAdaptiveProtectionConfig(securityPolicy.AdaptiveProtectionConfig)); err != nil { | |||
| return fmt.Errorf("Error setting adaptive_protection_config: %s", err) | |||
| } | |||
| if err := d.Set("rate_limit_options", flattenSecurityPolicyRateLimitOptions(securityPolicy.RateLimitOptions)); err != nil { | |||
There was a problem hiding this comment.
I think we're going to want to move all of this logic inside the flattenSecurityPolicyRules logic, since it is nested inside the rule. That being said, I think the type we're looking for here is called SecurityPolicyRuleRateLimitOptions.
|
Closing as stale, and because the linked issue is closed : hashicorp/terraform-provider-google#10020 If I'm incorrect please open a new PR in the upstream repo (GoogleCloudPlatform/magic-modules). Thanks! |
closes hashicorp/terraform-provider-google#10020
similar to hashicorp/terraform-provider-google#8984
todo:
do i need to add a pr to the main google repo to add the compute structs for
RateLimitOptions?