Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add update_mask_fields to healthcare_hl7_v2_store parser_config #3560

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#9870

We were sending only top-level fields to updateMask for parser_config, but parser_config.version was immutable, so we needed to break it down to the nested fields.

TIL update_mask_fields

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

healthcare: fixed bug where changes to `google_healthcare_hl7_v2_store.parser_config` subfields would error with '...parser_config.version field is immutable...`

Derived from GoogleCloudPlatform/magic-modules#5122

…icorp#5122)

* add update_mask_fields to healthcare_hl7_v2_store parser_config

* make parser_config default from api

* add tests

* make test changes beta-only

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 8879d77 into hashicorp:master Aug 24, 2021
@modular-magician modular-magician deleted the downstream-pr-15d0b2c3f4f8205c3d71edbcd4e0c8d012574bc2 branch November 16, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input=true not working for immutable field
1 participant