Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account for sql user names that are different for iam users #3442

Conversation

modular-magician
Copy link
Collaborator

Fxies hashicorp/terraform-provider-google#9553

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

sql: fixed bug that wouldn't insert the `google_sql_user` in state for iam users.

Derived from GoogleCloudPlatform/magic-modules#4984

…p#4984)

* fix bug for sql users using iam database authentication

* add tests

* add diffsuppress for name

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 4d14bcf into hashicorp:master Jul 23, 2021
rileykarson pushed a commit to rileykarson/terraform-provider-google-beta that referenced this pull request Nov 2, 2021
@modular-magician modular-magician deleted the downstream-pr-04970787fec1fe72d5ec1068b93a5f9e022d40d2 branch November 16, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant