Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apigee instance attachment resource #3093

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Apigee instance attachment resource #3093

merged 1 commit into from
Mar 30, 2021

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#8666, fixes hashicorp/terraform-provider-google#8756

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_apigee_instance_attachment`

Derived from GoogleCloudPlatform/magic-modules#4619

@modular-magician @slevenick @melinath
Apigee instance attachment resource (hashicorp#4619)
0894644 
* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Added code for Apigee environment groups

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Incorporating review comments for Apigee environment groups

* Incorporating review comments for Apigee environment groups

* Update reverse_check_membership.sh

* Update reverse_check_membership.sh

* Update check_membership.sh

* Update mmv1/products/apigee/api.yaml

Co-authored-by: Sam Levenick <[email protected]>

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update mmv1/products/apigee/api.yaml

Co-authored-by: Sam Levenick <[email protected]>

* fixing .ci errors

* added code for instance attachments

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update reverse_check_membership.sh

* Update reverse_check_membership.sh

* Update check_membership.sh

* Update mmv1/products/apigee/api.yaml

Co-authored-by: Sam Levenick <[email protected]>

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Added code for Apigee Environment

* Update api.yaml

* Update api.yaml

* Added code for Apigee Environment

* Update mmv1/products/apigee/api.yaml

Co-authored-by: Sam Levenick <[email protected]>

* fixing .ci errors

* added code for instance attachments

* fix for instance attachment create and delete

* instance attachment tests

* Update mmv1/templates/terraform/examples/apigee_instance_attachment_basic_test.tf.erb

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Update mmv1/templates/terraform/examples/apigee_instance_attachment_basic.tf.erb

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Made changes to instance attachment custom import

* removing depends_on as TF will implicitely calculate the dependencies now.

Co-authored-by: Sam Levenick <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added size/xl labels Mar 30, 2021
@modular-magician modular-magician merged commit 258c0a3 into hashicorp:master Mar 30, 2021
@modular-magician modular-magician deleted the downstream-pr-fa2d86cfa6aae4a594c010bf83e16e2fbce5e70b branch November 16, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apigee instance attachment resource Flakey tests: TestAccApigeeInstance_*
1 participant
@modular-magician