Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent locations in some resources - Part II #2863

Conversation

modular-magician
Copy link
Collaborator

@melinath

Part of GoogleCloudPlatform/magic-modules#4377

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

memcache: fixed an issue where `google_memcached_instance` resource was not inferring the region from the provider.
vpcaccess: fixed an issue where `google_vpc_access_connector` resource was not inferring the region from the provider.
tpu: fixed an issue where `google_tpu_node` resource was not inferring the zone from the provider.

Derived from GoogleCloudPlatform/magic-modules#4394

Co-authored-by: upodroid <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added size/m labels Jan 12, 2021
@modular-magician modular-magician merged commit e79e74a into hashicorp:master Jan 12, 2021
@modular-magician modular-magician deleted the downstream-pr-d2a45eba29eeefbc6e9757cd8bb774ccad0cadb1 branch November 16, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant