Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path_matcher in region url maps #2810

Conversation

modular-magician
Copy link
Collaborator

The default_service in path_matcher is actually not required as it should be default_service or default_url_redirect.
(related to hashicorp/terraform-provider-google#7951)

Further info in https://cloud.google.com/compute/docs/reference/rest/v1/regionUrlMaps , extract below:

pathMatchers[].defaultService
Only one of defaultService, defaultUrlRedirect or defaultRouteAction.weightedBackendService must be set.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_compute_region_url_map: removed requirement for default_service, as it should be a choice of default_service or default_url_redirect

Derived from GoogleCloudPlatform/magic-modules#4298

* Fix path_matcher in region url maps

The default_service in path_matcher is actually not required as it should be default_service or default_url_redirect.

Further info in https://cloud.google.com/compute/docs/reference/rest/v1/regionUrlMaps
> pathMatchers[].defaultService
>> Only one of defaultService, defaultUrlRedirect or defaultRouteAction.weightedBackendService must be set.

* Add testcase

* Update function name

Co-authored-by: Gilles Margerie <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added the size/m label Dec 22, 2020
@modular-magician modular-magician merged commit 3ad4530 into hashicorp:master Dec 22, 2020
@modular-magician modular-magician deleted the downstream-pr-fcbef9a71edca2cf454367228357c22491cd6628 branch November 16, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant