Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 #2760

Conversation

modular-magician
Copy link
Collaborator

Add Notebooks Terraform module v1 support for Notebooks API
Notebooks API is GA since September 2020.
New features are developed in v1 only. Updating Terraform.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

notebooks: promoted `google_notebooks_instance` to GA
notebooks: promoted `google_notebooks_environment` to GA

Derived from GoogleCloudPlatform/magic-modules#4253

* Update to v1 API

* Remove default option

* Restore v1beta1

* Update v1 order

* update iam tests to work correctly

* removed a < that corrupted compiliation

Co-authored-by: Scott Suarez <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added size/m labels Dec 4, 2020
@modular-magician modular-magician merged commit 0061ee4 into hashicorp:master Dec 4, 2020
@modular-magician modular-magician deleted the downstream-pr-37816f6c72fe6db67fd94b753b2d8295685b72e7 branch November 16, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant