Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stateful MIG -> GA #2544

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#7323.

Stateful MIG is controlled with PerInstanceConfig and RegionPerInstanceConfig. This PR makes those both available in GA as well as related utilities and tests.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: Marked `stateful_disk` as GA in `google_compute_ instance_group_manager` 
compute: Marked `stateful_disk` as GA in `google_compute_ region_instance_group_manager` 
compute: Marked `google_compute_ per_instance_config` as GA
compute: Marked `google_compute_ region_per_instance_config` as GA

Derived from GoogleCloudPlatform/magic-modules#4047

* Moved stateful MIG resources out of beta

* Ran gofmt on per_instance_config test files

* Promoted instance group manager fields out of beta

* Updated portions of region instance group manager that are out of beta

* Updated docs to not mark stateful_disk as a beta-only field

* Updated links to instance group manager beta docs

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 422c93b into hashicorp:master Oct 5, 2020
@modular-magician modular-magician deleted the downstream-pr-09a7ce63437a4f6c3a227eb03a278a3a8784c74a branch November 16, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stateful MIG beta timeline
1 participant