Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch http://www.gstatic.com/ipranges/goog.json to https Fixes #7155 #2448

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Switch http://www.gstatic.com/ipranges/goog.json to https Fixes #7155 #2448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/3934.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
compute: Fixed bug with `google_netblock_ip_ranges` data source failing to read from the correct URL
```
2 changes: 1 addition & 1 deletion google-beta/data_source_google_netblock_ip_ranges.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func dataSourceGoogleNetblockIpRangesRead(d *schema.ResourceData, meta interface
d.Set("cidr_blocks_ipv6", CidrBlocks["cidr_blocks_ipv6"])
case "google-netblocks":
// https://cloud.google.com/vpc/docs/configure-private-google-access?hl=en#ip-addr-defaults
const GOOGLE_NETBLOCK_URL = "http://www.gstatic.com/ipranges/goog.json"
const GOOGLE_NETBLOCK_URL = "https://www.gstatic.com/ipranges/goog.json"
CidrBlocks, err := getCidrBlocksFromUrl(GOOGLE_NETBLOCK_URL)

if err != nil {
Expand Down