Set context early on in LoadAndValidate to prevent NPE #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Modular Magician <[email protected]>
ghost
added
the
modular-magician
deleted the
downstream-pr-d52ce6787a7e428c5ad2b7b96bd14723cd1960ea
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not know that this will fix the problem, but I believe it will. Cannot reproduce crash locally even though context is verified to be nil going in to
creds, err := googleoauth.CredentialsFromJSON(c.context, []byte(contents), clientScopes...)Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3800