Mask GKE Sandbox-specific labels and taints #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Modular Magician <[email protected]>
ghost
added
the
modular-magician
deleted the
downstream-pr-de0746ebfdfe227127e1d8cdc3bdbcf71ee68d1a
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi friends,
This change prevents the GKE Sandbox labels and taints (currently
sandbox.gke.io/runtime=gvisor) from causing node pools to always need to be recreated. Without this change, once a node pool is created, it needs to be manually updated to include the additional GKE Sandbox label and taint items.I believe this PR fixes hashicorp/terraform-provider-google#4210.
The addition of the
DiffSuppressFuncon aTypeListis a little weird (not sure if it's using prescribed functionality or not; I see hashicorp/terraform-plugin-sdk#477 but it seems to work here). I'd be happy to take any suggestions on how to improve it.Once I get an OK on the general approach, I will add a few tests as well. Thanks for taking a look!
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3749