Fix broken indents by nested list bullets #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested a review
from 
danawillow
approved these changes
Dec 3, 2019
There was a problem hiding this comment.
Thanks for catching this @grauwoelfchen! This file is actually autogenerated from https://github.com/GoogleCloudPlatform/magic-modules, so I'll prepare a PR there that'll make the same change. Feel free to make any future changes there as well :)
|
@danawillow Oh, it's autogenerated! 😅 ... and you've merged also my useless change into above PR 🙇♀️ 💦 |
|
Eh I wanted to at least give you some credit :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just found a broken indents arround a section relates to
accessblock inbigquery_dataset.html.markdownfile 🙋♀️Problem
Current website shows the section like below. This may be a bit confusing:
Although it looks fine on GitHub...
On GitHub
Fix
Then, I've just removed a line break before a paragraph by 18160d5.
# I've checked the markdown rendering using redcarpet on local.
Before
Rendering result
After
Rendering result
I hope that it works.