Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: wait cloudrun to be ready #1256

Closed
wants to merge 1 commit into from
Closed

Conversation

tmshn
Copy link
Contributor

@tmshn tmshn commented Oct 11, 2019

This is super Work-In-Progress PR for hashicorp/terraform-provider-google#4091 which does NOT work yet.
I'll take holiday for 10 days from tomorrow, so anyone interested feel free to take over my work (otherwise, I'll do this after the vacation)

todos:

discussion point:

As far as I looked around the code, the Decoder function is the only place I can put the logic...but anyone has better idea?

@chrisst
Copy link

chrisst commented Oct 21, 2019

@tmshn As I suspect we will see more of these kuberenetes style status driven resource I'd love to see this turned into native Magic Modules functionality rather than bolted into the existing decoder. However let me know if you keep working on this and get something working and I'm happy to figure out a way to upstream it into magic modules.

@tmshn
Copy link
Contributor Author

tmshn commented Oct 30, 2019

@chrisst
Well actually...what I want to have initially was mm#2120 (oidcToken field of Pub/Sub), which have seemed to require this CloudRun behavior change.
However, now mm#2440 was merged, mm#2120 is no more needed. Thus, I don't need this PR neither now (currently I'm not using CloudRun).

I close this PR hoping someone takeover this problem.

I might work on this again when it become necessary to me (if there's something I can do).

@tmshn tmshn closed this Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants