Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IAM Conditions support; enable it in service account IAM #1188

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Add IAM Conditions support; enable it in service account IAM #1188

merged 1 commit into from
Oct 28, 2019

Conversation

modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Sep 25, 2019 •
edited
Loading

Original Author: @danawillow

iam: added support for IAM Conditions to the `google_service_account_iam_*` resources (beta provider only)

`google_service_account_iam_*` resources now support IAM Conditions. If any conditions had been created out of band before this release, take extra care to ensure they are present in your Terraform config so the provider doesn't try to create new bindings with no conditions. Terraform will show a diff that it is adding the condition to the resource, which is safe to apply.

@modular-magician modular-magician mentioned this pull request Sep 25, 2019
Merged
@ocervell
Copy link

ocervell commented Oct 8, 2019

@danawillow any idea when this will land ? Thanks 👍

@danawillow
Copy link
Contributor

Sorry for the holdup; I've been on vacation the last two weeks. I'll try to get this reviewed and merged this week so it can land in next week's release.

@ghost ghost added size/xxl and removed size/xl labels Oct 15, 2019
@ghost ghost added size/xl and removed size/xxl labels Oct 24, 2019
@modular-magician modular-magician force-pushed the codegen-pr-2372 branch 3 times, most recently from a5f2bed to ef74bda Compare October 25, 2019 17:32
@ghost ghost added size/xxl and removed size/xl labels Oct 25, 2019
@danawillow danawillow merged commit 67c66aa into hashicorp:master Oct 28, 2019
@modular-magician modular-magician deleted the codegen-pr-2372 branch November 15, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation size/xxl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@modular-magician @ocervell @danawillow