Skip to content

Commit

Permalink
Adding IAM support in Terraform for Dataform Repository resource (#94…
Browse files Browse the repository at this point in the history
…57) (#6648)

* Adding IAM support in Terraform for Dataform Repository resource

* Adding primary_resource_name property to Example

* Adding min-version: beta to IAM policy of repository resource

* Update import id used in acceptance tests

---------


[upstream:d7adf2e72dfaa14737ed4d1881bf1ac4af916bdf]

Signed-off-by: Modular Magician <[email protected]>
  • Loading branch information
modular-magician authored Nov 15, 2023
1 parent 65d8914 commit ccc8cdf
Show file tree
Hide file tree
Showing 6 changed files with 873 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .changelog/9457.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
dataform: added `google_dataform_repository_iam_*` IAM resources (beta)
```
8 changes: 6 additions & 2 deletions google-beta/provider/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -1072,6 +1072,7 @@ func DatasourceMapWithErrors() (map[string]*schema.Resource, error) {
"google_data_catalog_policy_tag_iam_policy": tpgiamresource.DataSourceIamPolicy(datacatalog.DataCatalogPolicyTagIamSchema, datacatalog.DataCatalogPolicyTagIamUpdaterProducer),
"google_data_catalog_tag_template_iam_policy": tpgiamresource.DataSourceIamPolicy(datacatalog.DataCatalogTagTemplateIamSchema, datacatalog.DataCatalogTagTemplateIamUpdaterProducer),
"google_data_catalog_taxonomy_iam_policy": tpgiamresource.DataSourceIamPolicy(datacatalog.DataCatalogTaxonomyIamSchema, datacatalog.DataCatalogTaxonomyIamUpdaterProducer),
"google_dataform_repository_iam_policy": tpgiamresource.DataSourceIamPolicy(dataform.DataformRepositoryIamSchema, dataform.DataformRepositoryIamUpdaterProducer),
"google_data_fusion_instance_iam_policy": tpgiamresource.DataSourceIamPolicy(datafusion.DataFusionInstanceIamSchema, datafusion.DataFusionInstanceIamUpdaterProducer),
"google_dataplex_asset_iam_policy": tpgiamresource.DataSourceIamPolicy(dataplex.DataplexAssetIamSchema, dataplex.DataplexAssetIamUpdaterProducer),
"google_dataplex_datascan_iam_policy": tpgiamresource.DataSourceIamPolicy(dataplex.DataplexDatascanIamSchema, dataplex.DataplexDatascanIamUpdaterProducer),
Expand Down Expand Up @@ -1146,8 +1147,8 @@ func DatasourceMapWithErrors() (map[string]*schema.Resource, error) {
}

// Generated resources: 396
// Generated IAM resources: 240
// Total generated resources: 636
// Generated IAM resources: 243
// Total generated resources: 639
func ResourceMap() map[string]*schema.Resource {
resourceMap, _ := ResourceMapWithErrors()
return resourceMap
Expand Down Expand Up @@ -1441,6 +1442,9 @@ func ResourceMapWithErrors() (map[string]*schema.Resource, error) {
"google_data_catalog_taxonomy_iam_member": tpgiamresource.ResourceIamMember(datacatalog.DataCatalogTaxonomyIamSchema, datacatalog.DataCatalogTaxonomyIamUpdaterProducer, datacatalog.DataCatalogTaxonomyIdParseFunc),
"google_data_catalog_taxonomy_iam_policy": tpgiamresource.ResourceIamPolicy(datacatalog.DataCatalogTaxonomyIamSchema, datacatalog.DataCatalogTaxonomyIamUpdaterProducer, datacatalog.DataCatalogTaxonomyIdParseFunc),
"google_dataform_repository": dataform.ResourceDataformRepository(),
"google_dataform_repository_iam_binding": tpgiamresource.ResourceIamBinding(dataform.DataformRepositoryIamSchema, dataform.DataformRepositoryIamUpdaterProducer, dataform.DataformRepositoryIdParseFunc),
"google_dataform_repository_iam_member": tpgiamresource.ResourceIamMember(dataform.DataformRepositoryIamSchema, dataform.DataformRepositoryIamUpdaterProducer, dataform.DataformRepositoryIdParseFunc),
"google_dataform_repository_iam_policy": tpgiamresource.ResourceIamPolicy(dataform.DataformRepositoryIamSchema, dataform.DataformRepositoryIamUpdaterProducer, dataform.DataformRepositoryIdParseFunc),
"google_dataform_repository_release_config": dataform.ResourceDataformRepositoryReleaseConfig(),
"google_dataform_repository_workflow_config": dataform.ResourceDataformRepositoryWorkflowConfig(),
"google_data_fusion_instance": datafusion.ResourceDataFusionInstance(),
Expand Down
245 changes: 245 additions & 0 deletions google-beta/services/dataform/iam_dataform_repository.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,245 @@
// Copyright (c) HashiCorp, Inc.
// SPDX-License-Identifier: MPL-2.0

// ----------------------------------------------------------------------------
//
// *** AUTO GENERATED CODE *** Type: MMv1 ***
//
// ----------------------------------------------------------------------------
//
// This file is automatically generated by Magic Modules and manual
// changes will be clobbered when the file is regenerated.
//
// Please read more about how to change this file in
// .github/CONTRIBUTING.md.
//
// ----------------------------------------------------------------------------

package dataform

import (
"fmt"

"github.com/hashicorp/errwrap"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"google.golang.org/api/cloudresourcemanager/v1"

"github.com/hashicorp/terraform-provider-google-beta/google-beta/tpgiamresource"
"github.com/hashicorp/terraform-provider-google-beta/google-beta/tpgresource"
transport_tpg "github.com/hashicorp/terraform-provider-google-beta/google-beta/transport"
)

var DataformRepositoryIamSchema = map[string]*schema.Schema{
"project": {
Type: schema.TypeString,
Computed: true,
Optional: true,
ForceNew: true,
},
"region": {
Type: schema.TypeString,
Computed: true,
Optional: true,
ForceNew: true,
},
"repository": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
DiffSuppressFunc: tpgresource.CompareSelfLinkOrResourceName,
},
}

type DataformRepositoryIamUpdater struct {
project string
region string
repository string
d tpgresource.TerraformResourceData
Config *transport_tpg.Config
}

func DataformRepositoryIamUpdaterProducer(d tpgresource.TerraformResourceData, config *transport_tpg.Config) (tpgiamresource.ResourceIamUpdater, error) {
values := make(map[string]string)

project, _ := tpgresource.GetProject(d, config)
if project != "" {
if err := d.Set("project", project); err != nil {
return nil, fmt.Errorf("Error setting project: %s", err)
}
}
values["project"] = project
region, _ := tpgresource.GetRegion(d, config)
if region != "" {
if err := d.Set("region", region); err != nil {
return nil, fmt.Errorf("Error setting region: %s", err)
}
}
values["region"] = region
if v, ok := d.GetOk("repository"); ok {
values["repository"] = v.(string)
}

// We may have gotten either a long or short name, so attempt to parse long name if possible
m, err := tpgresource.GetImportIdQualifiers([]string{"projects/(?P<project>[^/]+)/locations/(?P<region>[^/]+)/repositories/(?P<repository>[^/]+)", "(?P<project>[^/]+)/(?P<region>[^/]+)/(?P<repository>[^/]+)", "(?P<region>[^/]+)/(?P<repository>[^/]+)", "(?P<repository>[^/]+)"}, d, config, d.Get("repository").(string))
if err != nil {
return nil, err
}

for k, v := range m {
values[k] = v
}

u := &DataformRepositoryIamUpdater{
project: values["project"],
region: values["region"],
repository: values["repository"],
d: d,
Config: config,
}

if err := d.Set("project", u.project); err != nil {
return nil, fmt.Errorf("Error setting project: %s", err)
}
if err := d.Set("region", u.region); err != nil {
return nil, fmt.Errorf("Error setting region: %s", err)
}
if err := d.Set("repository", u.GetResourceId()); err != nil {
return nil, fmt.Errorf("Error setting repository: %s", err)
}

return u, nil
}

func DataformRepositoryIdParseFunc(d *schema.ResourceData, config *transport_tpg.Config) error {
values := make(map[string]string)

project, _ := tpgresource.GetProject(d, config)
if project != "" {
values["project"] = project
}

region, _ := tpgresource.GetRegion(d, config)
if region != "" {
values["region"] = region
}

m, err := tpgresource.GetImportIdQualifiers([]string{"projects/(?P<project>[^/]+)/locations/(?P<region>[^/]+)/repositories/(?P<repository>[^/]+)", "(?P<project>[^/]+)/(?P<region>[^/]+)/(?P<repository>[^/]+)", "(?P<region>[^/]+)/(?P<repository>[^/]+)", "(?P<repository>[^/]+)"}, d, config, d.Id())
if err != nil {
return err
}

for k, v := range m {
values[k] = v
}

u := &DataformRepositoryIamUpdater{
project: values["project"],
region: values["region"],
repository: values["repository"],
d: d,
Config: config,
}
if err := d.Set("repository", u.GetResourceId()); err != nil {
return fmt.Errorf("Error setting repository: %s", err)
}
d.SetId(u.GetResourceId())
return nil
}

func (u *DataformRepositoryIamUpdater) GetResourceIamPolicy() (*cloudresourcemanager.Policy, error) {
url, err := u.qualifyRepositoryUrl("getIamPolicy")
if err != nil {
return nil, err
}

project, err := tpgresource.GetProject(u.d, u.Config)
if err != nil {
return nil, err
}
var obj map[string]interface{}

userAgent, err := tpgresource.GenerateUserAgentString(u.d, u.Config.UserAgent)
if err != nil {
return nil, err
}

policy, err := transport_tpg.SendRequest(transport_tpg.SendRequestOptions{
Config: u.Config,
Method: "GET",
Project: project,
RawURL: url,
UserAgent: userAgent,
Body: obj,
})
if err != nil {
return nil, errwrap.Wrapf(fmt.Sprintf("Error retrieving IAM policy for %s: {{err}}", u.DescribeResource()), err)
}

out := &cloudresourcemanager.Policy{}
err = tpgresource.Convert(policy, out)
if err != nil {
return nil, errwrap.Wrapf("Cannot convert a policy to a resource manager policy: {{err}}", err)
}

return out, nil
}

func (u *DataformRepositoryIamUpdater) SetResourceIamPolicy(policy *cloudresourcemanager.Policy) error {
json, err := tpgresource.ConvertToMap(policy)
if err != nil {
return err
}

obj := make(map[string]interface{})
obj["policy"] = json

url, err := u.qualifyRepositoryUrl("setIamPolicy")
if err != nil {
return err
}
project, err := tpgresource.GetProject(u.d, u.Config)
if err != nil {
return err
}

userAgent, err := tpgresource.GenerateUserAgentString(u.d, u.Config.UserAgent)
if err != nil {
return err
}

_, err = transport_tpg.SendRequest(transport_tpg.SendRequestOptions{
Config: u.Config,
Method: "POST",
Project: project,
RawURL: url,
UserAgent: userAgent,
Body: obj,
Timeout: u.d.Timeout(schema.TimeoutCreate),
})
if err != nil {
return errwrap.Wrapf(fmt.Sprintf("Error setting IAM policy for %s: {{err}}", u.DescribeResource()), err)
}

return nil
}

func (u *DataformRepositoryIamUpdater) qualifyRepositoryUrl(methodIdentifier string) (string, error) {
urlTemplate := fmt.Sprintf("{{DataformBasePath}}%s:%s", fmt.Sprintf("projects/%s/locations/%s/repositories/%s", u.project, u.region, u.repository), methodIdentifier)
url, err := tpgresource.ReplaceVars(u.d, u.Config, urlTemplate)
if err != nil {
return "", err
}
return url, nil
}

func (u *DataformRepositoryIamUpdater) GetResourceId() string {
return fmt.Sprintf("projects/%s/locations/%s/repositories/%s", u.project, u.region, u.repository)
}

func (u *DataformRepositoryIamUpdater) GetMutexKey() string {
return fmt.Sprintf("iam-dataform-repository-%s", u.GetResourceId())
}

func (u *DataformRepositoryIamUpdater) DescribeResource() string {
return fmt.Sprintf("dataform repository %q", u.GetResourceId())
}
Loading

0 comments on commit ccc8cdf

Please sign in to comment.