Skip to content

Commit

Permalink
Modify test to use lowercase, add case diff suppress on node config i…
Browse files Browse the repository at this point in the history
…mage_type (#4029) (#2538)

Signed-off-by: Modular Magician <[email protected]>
  • Loading branch information
modular-magician authored Oct 2, 2020
1 parent 0eb8fff commit 3e71bf8
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
3 changes: 3 additions & 0 deletions .changelog/4029.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
container: fixed `node_config.image_type` perma-diff when specified in lower case.
```
7 changes: 4 additions & 3 deletions google-beta/node_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,10 @@ func schemaNodeConfig() *schema.Schema {
},

"image_type": {
Type: schema.TypeString,
Optional: true,
Computed: true,
Type: schema.TypeString,
Optional: true,
Computed: true,
DiffSuppressFunc: caseDiffSuppress,
},

"labels": {
Expand Down
2 changes: 1 addition & 1 deletion google-beta/resource_container_cluster_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2830,7 +2830,7 @@ resource "google_container_cluster" "with_node_config" {
}
// Updatable fields
image_type = "COS"
image_type = "cos"
}
}
`, clusterName)
Expand Down

0 comments on commit 3e71bf8

Please sign in to comment.