Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: GitHub Actions #122

Merged
merged 4 commits into from
Jul 8, 2021
Merged

CI: GitHub Actions #122

merged 4 commits into from
Jul 8, 2021

Conversation

kmoe
Copy link
Member

@kmoe kmoe commented Feb 1, 2021

Remove the old Travis config, and run PR tests via GitHub Actions.

The krb5-user package is required for kinit, used in acceptance.sh.

We skip TestAccDataDnsTxtRecordSet_Basic due to a failure we can't reproduce anywhere except the GHA runner and will need to investigate later: #154

@ghost ghost added the size/M label Feb 1, 2021
@kmoe kmoe force-pushed the basic-github-actions branch 8 times, most recently from 469cee7 to 9c8edcc Compare February 2, 2021 19:02
@kmoe kmoe force-pushed the basic-github-actions branch 2 times, most recently from 0196f2c to 8e697e0 Compare February 23, 2021 18:24
@bflad
Copy link
Contributor

bflad commented May 5, 2021

Ready for updates from other similar pull requests! 👍

@bflad bflad self-assigned this May 5, 2021
@kmoe
Copy link
Member Author

kmoe commented May 6, 2021

Could the fail be related to the CGO DNS issues (golang/go#25321 etc)?

@kmoe kmoe force-pushed the basic-github-actions branch 2 times, most recently from 0bdc981 to 199ebd1 Compare June 24, 2021 15:49
@kmoe
Copy link
Member Author

kmoe commented Jun 24, 2021

The test failure:

=== RUN   TestAccDataDnsTxtRecordSet_Basic
    data_dns_txt_record_set_test.go:13: Step 1/1 error: Error running pre-apply refresh: exit status 1
        2021/06/24 15:53:58 [DEBUG] Using modified User-Agent: Terraform/0.12.30 HashiCorp-terraform-exec/0.13.3
        
        Error: error looking up TXT records for "terraform.io": lookup terraform.io on 127.0.0.53:53: no such host
        
          on terraform_plugin_test.tf line 2, in data "dns_txt_record_set" "test":
           2: data "dns_txt_record_set" "test" {
        
        
--- FAIL: TestAccDataDnsTxtRecordSet_Basic (11.55s)

@github-actions github-actions bot added size/L and removed size/M labels Jul 1, 2021
@kmoe kmoe force-pushed the basic-github-actions branch from 0362455 to b2ff810 Compare July 1, 2021 15:14
@bflad
Copy link
Contributor

bflad commented Jul 1, 2021

macOS support may require some parts of #144, but unsure how the runners differ from an actual workstation.

@kmoe kmoe force-pushed the basic-github-actions branch from cef5a98 to b03dcc0 Compare July 8, 2021 08:59
@github-actions github-actions bot added size/M and removed size/L labels Jul 8, 2021
@kmoe kmoe force-pushed the basic-github-actions branch from db7f38f to cd021c7 Compare July 8, 2021 10:11
@kmoe kmoe changed the title test: GitHub Actions CI: GitHub Actions Jul 8, 2021
@kmoe kmoe marked this pull request as ready for review July 8, 2021 10:24
@kmoe kmoe requested a review from bflad July 8, 2021 10:25
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for opening that separate issue and implementing the TXT data source test workaround for now. 🚀

@kmoe kmoe merged commit e447cd4 into main Jul 8, 2021
@kmoe kmoe deleted the basic-github-actions branch July 8, 2021 14:31
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants