-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: GitHub Actions #122
CI: GitHub Actions #122
Conversation
469cee7
to
9c8edcc
Compare
0196f2c
to
8e697e0
Compare
Ready for updates from other similar pull requests! 👍 |
Could the fail be related to the CGO DNS issues (golang/go#25321 etc)? |
0bdc981
to
199ebd1
Compare
The test failure:
|
0362455
to
b2ff810
Compare
macOS support may require some parts of #144, but unsure how the runners differ from an actual workstation. |
cef5a98
to
b03dcc0
Compare
db7f38f
to
cd021c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for opening that separate issue and implementing the TXT data source test workaround for now. 🚀
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Remove the old Travis config, and run PR tests via GitHub Actions.
The
krb5-user
package is required forkinit
, used inacceptance.sh
.We skip
TestAccDataDnsTxtRecordSet_Basic
due to a failure we can't reproduce anywhere except the GHA runner and will need to investigate later: #154