Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): Support worker filter on dynamic host catalogs #626

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

hugoghx
Copy link
Contributor

@hugoghx hugoghx commented Oct 1, 2024

No description provided.

@hugoghx hugoghx self-assigned this Oct 1, 2024
@hugoghx hugoghx force-pushed the hugo-dhc-workerfilter branch from 00b11db to 2a1ba22 Compare October 9, 2024 14:24
@hugoghx

This comment was marked as resolved.

@hugoghx hugoghx requested a review from louisruch October 9, 2024 14:28
@hugoghx hugoghx marked this pull request as ready for review October 9, 2024 14:28
go.mod Show resolved Hide resolved
@hugoghx hugoghx force-pushed the hugo-dhc-workerfilter branch from acd3e53 to 9d5d0ec Compare October 10, 2024 11:18
@hugoghx hugoghx requested a review from louisruch October 10, 2024 11:41
Copy link
Contributor

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the most part one question on HCP Only vs Enterprise Only wording.

We will also need to include a changelog entry for the addition of worker filter

docs/resources/host_catalog_plugin.md Show resolved Hide resolved
@hugoghx hugoghx force-pushed the hugo-dhc-workerfilter branch 2 times, most recently from fc7f471 to 4efc373 Compare October 17, 2024 14:37
@hugoghx hugoghx force-pushed the hugo-dhc-workerfilter branch from 4efc373 to dd817de Compare October 17, 2024 14:38
Copy link
Contributor

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM dont push a tag just yet

@hugoghx hugoghx merged commit 1c1c095 into main Oct 21, 2024
6 checks passed
@hugoghx hugoghx deleted the hugo-dhc-workerfilter branch October 21, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants