Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add port to example addr #59

Merged
merged 1 commit into from
Oct 21, 2020
Merged

docs: add port to example addr #59

merged 1 commit into from
Oct 21, 2020

Conversation

ksatirli
Copy link
Member

This PR adds the port to the example addr to be consistent with the addr listed earlier.

@ksatirli ksatirli changed the title add port to example addr docs: add port to example addr Oct 15, 2020
@malnick
Copy link
Contributor

malnick commented Oct 15, 2020

Thanks @ksatirli - These docs are actually auto-generated. To update this, can you update the provider help text for the addr attribute in https://github.com/hashicorp/terraform-provider-boundary/blob/main/internal/provider/provider.go#L28, then run the following to generate the docs:

  1. Generate following these instructions: https://github.com/hashicorp/terraform-provider-boundary#generating-docs
  2. Remove the unused id attribute (should have this fixed in our upstream docs generation soon!) using this Makefile target: https://github.com/hashicorp/terraform-provider-boundary/blob/main/Makefile#L44

Thanks again for the contribution!

@malnick malnick self-requested a review October 15, 2020 15:56
@malnick malnick added the documentation Improvements or additions to documentation label Oct 15, 2020
@malnick
Copy link
Contributor

malnick commented Oct 19, 2020

Per this PR, you should be able to pull main and not have to worry about id overrides: #54

Let me know if you have any issues.

@malnick malnick merged commit cadd424 into hashicorp:main Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants