-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(oidc): OIDC Prompt Support #519
Conversation
go.mod
Outdated
github.com/hashicorp/boundary v0.14.3-0.20231121173019-2cd2d4ecfceb | ||
github.com/hashicorp/boundary/api v0.0.44-0.20231121173019-2cd2d4ecfceb | ||
github.com/hashicorp/boundary/sdk v0.0.41-0.20231121173019-2cd2d4ecfceb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: This will be updated with the new release once ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A few minor suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty!
Boundary OIDC method does not currently support passing in prompts during authentication. This change adds the capability of passing OIDC prompts. Prompts are optional OIDC parameters that determine the behaviour of the authentication server: https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest Add new optional `prompts` option to `boundary_auth_method_oidc` resource. `prompts` option are optional OIDC parameters that determine the behavior of the authentication server.
9935918
to
eda77fe
Compare
Boundary OIDC method does not currently support passing in prompts during authentication. This change adds the capability of passing OIDC prompts. Prompts are optional OIDC parameters that determine the behaviour of the authentication server: https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest
NOTE: This PR will not be merged until the latest release is out. This is needed to update
boundary
,boundary/api
&boundary/sdk
dependencies.Changes
Add new optional
prompts
option toboundary_auth_method_oidc
resource.prompts
option are optional OIDC parameters that determine the behavior of the authentication server.Examples