enable support for ssh valid certs additional valid principals field #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kheina
force-pushed
the
dmiu_additional-valid-principals
branch
2 times, most recently
from
26af8b5 to
6dffcc6
Compare
kheina
force-pushed
the
dmiu_additional-valid-principals
branch
from
6dffcc6 to
2abbbe8
Compare
|
LGTM. Can you please add an example so it's easier for folks to use/set up |
ddebko
requested changes
Nov 6, 2023
There was a problem hiding this comment.
There is some weird output I have never seen before from the unit tests:
Error: ../../../go/pkg/mod/github.com/hashicorp/[email protected]/internal/kms/kms.go:603:37: type func(i "github.com/hashicorp/go-kms-wrapping/extras/kms/v2".KeyVersion, j "github.com/hashicorp/go-kms-wrapping/extras/kms/v2".KeyVersion) bool of func(i, j wrappingKms.KeyVersion) bool {…} does not match inferred type func(a "github.com/hashicorp/go-kms-wrapping/extras/kms/v2".KeyVersion, b "github.com/hashicorp/go-kms-wrapping/extras/kms/v2".KeyVersion) int for func(a E, b E) int
This might just be a conflict with versioning in the go mod?
ddebko
force-pushed
the
dmiu_additional-valid-principals
branch
from
1ff0412 to
2abbbe8
Compare
|
This PR needs to be kept open until the next release of Boundary fixes the dependency issues with the following package. Afterwards, this PR will need to be updated with the latest Boundary version. |
|
|
This should be fixed now |
ddebko
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enables support for hashicorp/boundary#3791
note: requires the next version of boundary 0.14.2 to be released and go.mod updated before being merged