feat: add user resource #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malnick
force-pushed
the
ICU-257
branch
4 times, most recently
from
41bf6b8 to
b220dbf
Compare
talanknight
reviewed
Jun 23, 2020
|
|
||
| u := convertResourceDataToUser(d) | ||
|
|
||
| if d.HasChange(userNameKey) { |
There was a problem hiding this comment.
For both name and description, check to see if d.Get(userNameKey) returns an empty string and if so set the u.SetDefault("user_name") and u.SetDefault("description") in those cases. This will allow these fields to be unset completely instead of being set to an empty string.
There was a problem hiding this comment.
What do you want to set them to if they're an empty string?
| fooUserDescriptionUpdate = "foo bar" | ||
| ) | ||
|
|
||
| var ( |
There was a problem hiding this comment.
consider adding a test for updating a field to be unset.
| @@ -26,6 +26,7 @@ func New() terraform.ResourceProvider { | |||
| ResourcesMap: map[string]*schema.Resource{ | |||
| "watchtower_project": resourceProject(), | |||
| "watchtower_host_catalog": resourceHostCatalog(), | |||
| "watchtower_user": resourceUser(), | |||
There was a problem hiding this comment.
Consider reordering these keys to be sorted lexicographically to make it easier to track down the resources as this list grows larger.
talanknight
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the user resource.