Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scope datasource, tests, and docs #474

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Conversation

grantorchard
Copy link
Contributor

For different configuration workflows, we need to pass the scope id in as an argument. This data source allows discovery of a scope by its name which is a smoother pattern than needing to login to the UI to discover it.

Replaces #304.

@drewmullen
Copy link
Contributor

The only thing I might recommend is that in the docs explain with a info block that using this data source for the global scope is unnecessary. When I was first learning boundary I got hung up on finding out the "id" of the global scope... which is "global" lol

You could probably DRY some of the config in your test w the configs in the scope resource but that memory savings is pretty minimal

Copy link
Contributor

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psekar psekar added this to the 0.14.x milestone Oct 10, 2023
@grantorchard
Copy link
Contributor Author

The only thing I might recommend is that in the docs explain with a info block that using this data source for the global scope is unnecessary. When I was first learning boundary I got hung up on finding out the "id" of the global scope... which is "global" lol

You could probably DRY some of the config in your test w the configs in the scope resource but that memory savings is pretty minimal

Thanks for the feedback, I've added a comment on the global scope to that effect.

@psekar psekar merged commit c3b08a1 into hashicorp:main Oct 11, 2023
@grantorchard grantorchard mentioned this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants