docs: update host set plugin filters examples #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to update the example docs for `host_set_plugin` filters attribute to use a list strings instead of just strings. AWS host set plugin expects filters attributes to be passed as a list of strings instead of strings. It is currently backwards compatible with strings due to the migration [normalizeData func](https://github.com/hashicorp/boundary-plugin-aws/blob/7bf9fe2ecf1f20d7ff8aea8306909abcde1d17a4/plugin/service/host/plugin.go#L256) on AWS host plugin. Previously this was not working but [Boundary PR-3338](hashicorp/boundary#3338) fixed the bug.
talanknight
reviewed
Jun 23, 2023
Comment on lines
-62
to
-63
| "filters" = "tag-key=foo", | ||
| "filters" = "tag-key=bar" |
There was a problem hiding this comment.
Huh, would this example ever have worked? wouldn't jsonencode just set the "filters" key to whatever is defined last?
There was a problem hiding this comment.
Yeah, I don't think it's a valid example. It'd have always just used the last "filters" key
elimt
added a commit
that referenced
this pull request
Jun 28, 2023
This change is to update the example docs for `host_set_plugin` filters attribute to use a list strings instead of just strings. WIthout using a list of strings, Terraform will falsely detect diffs with host set plugin `filters`. AWS host set plugin expects filters attributes to be passed as a list of strings instead of strings. It is currently backwards compatible with strings due to the migration [normalizeData func](https://github.com/hashicorp/boundary-plugin-aws/blob/7bf9fe2ecf1f20d7ff8aea8306909abcde1d17a4/plugin/service/host/plugin.go#L256) on AWS host plugin. Previously this was not working but [Boundary PR-3338](hashicorp/boundary#3338) fixed the bug.
grantorchard
pushed a commit
to grantorchard/terraform-provider-boundary
that referenced
this pull request
Aug 28, 2023
This change is to update the example docs for `host_set_plugin` filters attribute to use a list strings instead of just strings. WIthout using a list of strings, Terraform will falsely detect diffs with host set plugin `filters`. AWS host set plugin expects filters attributes to be passed as a list of strings instead of strings. It is currently backwards compatible with strings due to the migration [normalizeData func](https://github.com/hashicorp/boundary-plugin-aws/blob/7bf9fe2ecf1f20d7ff8aea8306909abcde1d17a4/plugin/service/host/plugin.go#L256) on AWS host plugin. Previously this was not working but [Boundary PR-3338](hashicorp/boundary#3338) fixed the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to update the example docs for
host_set_pluginfilters attribute to use a list strings instead of just strings.WIthout using a list of strings, Terraform will falsely detect diffs with host set plugin
filters.AWS host set plugin expects filters attributes to be passed as a list of strings instead of strings. It is currently backwards compatible with strings due to the migration normalizeData func on AWS host plugin.
Previously this was not working onCreate but Boundary PR-3338 fixed the bug.