fix(credlib): Force new resource on credential_type change #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisruch
approved these changes
May 3, 2023
elimt
pushed a commit
that referenced
this pull request
May 4, 2023
elimt
added a commit
that referenced
this pull request
May 5, 2023
* feature: Use default auth method if no auth method ID is provided for provider (#385) * Use default auth method if no auth method ID is provided for provider * docs: Fix typo in Managed Group resource page (#370) * fix(credlib): Force new resource on credential_type change (#389) * update changelog --------- Co-authored-by: Dan Heath <[email protected]> Co-authored-by: Hugo <[email protected]>
grantorchard
pushed a commit
to grantorchard/terraform-provider-boundary
that referenced
this pull request
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where if the
credential_typein aboundary_credential_library_vaultresource is changed, TF will register the change and report that the resource was updated but doesn't actually changecredential_type.This is because
credential_typeis immutable in Boundary and we don't take it into account when updating aboundary_credential_library_vaultresource, so this isn't actually valid operation.I wasn't able to write tests for this, but I was able to manually validate it