-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add worker_filter option to Boundary Credential Store Vault #375
feature: add worker_filter option to Boundary Credential Store Vault #375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add a test for this new variable?
@johanbrandhorst I don't think we can, since it's an HCP only feature and depends on having a Vault instance and PKI worker up and running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'd just ask that you manually test it works before merging.
Manually verified 👍 |
…375) * feature: add worker_filter option to Boundary Credential Store Vault * Update changelog
* fix: Allow users to set OIDC maxAge value to 0 to require immediate reauth (#364) * fix: Allow users to set OIDC maxAge value to 0 to require immediate reauth Previously, setting 0 as a value for maxAge in an OIDC resource block would not update Boundary, as it was getting treated as a nil value in the provider. This fix addresses that issue, ensuring that both setting the value to 0 will require immediate reauthorisation, as well as removing the maxAge paramater defaulting the reauth time length to the TTL of the chose OIDC provider * Update doc strings, fix imports, and run go generate * add changes to CHANGELOG * spelling: host_set_plugin exmaple to example * Update target.md (#349) Update docs for Target resource removing `scope_id` from `boundary_host` resources to prevent error ``` ╷ │ Error: Unsupported argument │ │ on main.tf line 79, in resource "boundary_host" "foo": │ 79: scope_id = boundary_scope.project.id │ │ An argument named "scope_id" is not expected here. ``` * feature: add worker_filter option to Boundary Credential Store Vault (#375) * feature: add worker_filter option to Boundary Credential Store Vault * Update changelog * chore: update deps * small fixes for cherry-picks * downgrade hclog --------- Co-authored-by: mocofound <[email protected]> Co-authored-by: Steven Zamborsky <[email protected]> Co-authored-by: Louis Ruch <[email protected]>
…ashicorp#375) * feature: add worker_filter option to Boundary Credential Store Vault * Update changelog
Closes #294