feat: add hostset resource #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
reviewed
Sep 2, 2020
jefferai
reviewed
Sep 2, 2020
jefferai
reviewed
Sep 2, 2020
| // convertResourceDataToHostset returns a localy built Host using the values provided in the ResourceData. | ||
| func convertResourceDataToHostset(d *schema.ResourceData) *hostsets.HostSet { | ||
| // if you're manually defining the hostset in TF, it's always going | ||
| // to be of type "static" |
There was a problem hiding this comment.
Not true! Only if it's in a static host catalog.
In future catalogs, you might define a host set minaly via attributes, e.g. you're defining the predicate used to filter hosts coming from a cloud. It's still going to depend on the host catalog type though.
There was a problem hiding this comment.
To be clear I don't think we need to change anything as a result but might be good to get rid of that comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds resource for hostset.