Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(kms): Add support for all Boundary supported KMSes #213

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

louisruch
Copy link
Contributor

@louisruch louisruch commented Jun 1, 2022

Fixes #209
After moving to go-kms-wrapping V2, the Boundary Terraform Provider
did not load all KMS plugins resulting in an error when trying to
create a wrapper for any type other than aead:

Error: error reading wrappers from "recovery_kms_hcl":
Error configuring kms: plugin is nil

@louisruch louisruch marked this pull request as draft June 1, 2022 16:56
@louisruch louisruch requested a review from jefferai June 1, 2022 19:33
@louisruch louisruch marked this pull request as ready for review June 1, 2022 19:34
After moving to go-kms-wrapping V2, the Boundary Terraform Provider
did not load all KMS plugins resulting in an error when trying to
create a wrapper for any type other than aead:

    Error: error reading wrappers from "recovery_kms_hcl":
    Error configuring kms: plugin is nil
Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but longer term we should have a plan to share assets between Boundary and the TF provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recovery KMS HCL stop working after upgrade from 1.0.6 to 1.0.7
2 participants