feat: add grants to roles #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talanknight
approved these changes
Jul 11, 2020
| return fmt.Errorf("Got an error when reading role %q: %v", id, err) | ||
| } | ||
|
|
||
| fmt.Printf("[DEBUG] got role for grant: %+v", r) |
internal/provider/resource_role.go
Outdated
| if len(grants) > 0 { | ||
| r, apiErr, err = r.AddGrants(ctx, grants) | ||
| if apiErr != nil || err != nil { | ||
| return fmt.Errorf("error setting grants on role:\n API Err: %+v\n Err: %+v\n", *apiErr.Message, err) |
There was a problem hiding this comment.
if apiErr is nil at this point this will result in a panic.
There was a problem hiding this comment.
Update to not reference an attribute of the API error type and include %+v everywhere so we expose the field values in the message. Not perfect, but also won't panic.
malnick
force-pushed
the
grants
branch
2 times, most recently
from
c846af3 to
5fc7e5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.