Create Watchtower Project Resources #1
Conversation
…wn helper methods.
| }, | ||
| ResourcesMap: map[string]*schema.Resource{ | ||
| "scaffolding_resource": resourceScaffolding(), | ||
| "watchtower_project": resourceProject(), |
There was a problem hiding this comment.
Since the provider is called watchtower I vote to have the key here be just project so it doesn't duplicate the primary namespace of the provider.
There was a problem hiding this comment.
I'm happy to make the change. I thought that since different providers can be included in a single tf config the resources needed to be named in a way that won't collide with resources from other providers. For example, all github related resources have a "github_" prefix and the google related resources have "google_" prefix.
There was a problem hiding this comment.
On second thought, I agree with your assessment. This makes sense as-is, let's leave it.
| client.SetOrg(d.Get("default_organization").(string)) | ||
|
|
||
| // TODO: Pass these in through the config, add token, etc... | ||
| client.SetLimiter(5, 5) |
There was a problem hiding this comment.
Do we want to expose the SetLimiter values in the provider schema?
There was a problem hiding this comment.
Maybe at first? I think in the long run we may want to set a reasonable initial default and then allow the controller and go client to handle backoffs and retries. Thoughts?
| Update: resourceProjectUpdate, | ||
| Delete: resourceProjectDelete, | ||
|
|
||
| // TODO: Add the ability to define a parent org instead of using one defined in the provider. |
There was a problem hiding this comment.
This comment surfaced some interesting thinking about architecture here: do we want resources within an instance of this provider to be able to provision resources within another org not declared outside the provider instance?
If we do allow resources to be created within orgs that are not globally defined to the instance of the provider, we'll have to bake in org logic into every resource within the provider. There was a similar issue with Vault's provider and Namespace support.
There was a problem hiding this comment.
I made this TODO and changed the provider's schema key from "organization" to "default_organization" after a comment from @jefferai where he seemed to hint at the need to do multi org config in a single tf config. The go client does facilitate setting a default org for the whole client and allowing a per call override. I think that would just mean that the resource logic would be checking to see for an org defined at the resource level and if so, using that for the calls through the go client.
This PR adds watchtower provider, and the project resource.
Acceptance tests will be added later as I figure out the best way to spin up a watchtower instance in association with the test.