Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurestack_public_ip: correct import & read idle_timeout_in_minutes #42

Merged
merged 3 commits into from
Sep 14, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Sep 13, 2018

fixes the following import error:

------- Stdout: -------
=== RUN   TestAccAzureStackPublicIpStatic_idleTimeout
--- FAIL: TestAccAzureStackPublicIpStatic_idleTimeout (71.27s)
	testing.go:513: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
		
		(map[string]string) {
		}
		
		
		(map[string]string) (len=1) {
		 (string) (len=23) "idle_timeout_in_minutes": (string) (len=2) "30"
		}
		
FAIL

(and its nice if changes to the value are read back in)

@katbyte katbyte added the bug label Sep 13, 2018
@katbyte katbyte added this to the 0.4.0 milestone Sep 13, 2018
@ghost ghost added the size/L label Sep 13, 2018
@katbyte
Copy link
Collaborator Author

katbyte commented Sep 13, 2018

Tests all pass:
screen shot 2018-09-13 at 16 35 25

@katbyte katbyte force-pushed the b-publicip-idle_timeout branch from 77b0e5e to 41f0e1c Compare September 14, 2018 03:19
@ghost ghost added the size/L label Sep 14, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katbyte katbyte merged commit b2b3164 into master Sep 14, 2018
@katbyte katbyte deleted the b-publicip-idle_timeout branch September 14, 2018 15:51
katbyte added a commit that referenced this pull request Sep 14, 2018
@ghost
Copy link

ghost commented Jun 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants