Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to virtual network gateway validation #36

Merged
merged 1 commit into from
Sep 8, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Sep 8, 2018

Optional values can have an empty ID (allows for interpolation)

@katbyte katbyte added the bug label Sep 8, 2018
@katbyte katbyte added this to the 0.4.0 milestone Sep 8, 2018
@katbyte katbyte requested a review from a team September 8, 2018 16:35
@ghost ghost added the size/XS label Sep 8, 2018
Copy link

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katbyte katbyte merged commit 8a7ed3d into master Sep 8, 2018
@katbyte katbyte deleted the vng-validation_update branch September 8, 2018 21:52
@ghost
Copy link

ghost commented Jun 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants