Merge pull request #92 from terraform-providers/r/p-test

switch from `resource.Test()` to `resource.ParallelTest()`
hashicorp · Jun 20, 2019 · 0e6d702 · 0e6d702
2 parents 4d6eeac + c6d3607
commit 0e6d702
Show file tree

Hide file tree

Showing 37 changed files with 184 additions and 184 deletions.
diff --git a/azurestack/data_source_client_config_test.go b/azurestack/data_source_client_config_test.go
@@ -15,7 +15,7 @@ func TestAccDataSourceAzureStackClientConfig_basic(t *testing.T) {
 	tenantId := os.Getenv("ARM_TENANT_ID")
 	subscriptionId := os.Getenv("ARM_SUBSCRIPTION_ID")
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{

diff --git a/azurestack/data_source_network_interface_test.go b/azurestack/data_source_network_interface_test.go
@@ -14,7 +14,7 @@ func TestAccDataSourceArmVirtualNetworkInterface_basic(t *testing.T) {
 
 	name := fmt.Sprintf("acctest-nic-%d", ri)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{

diff --git a/azurestack/data_source_network_security_group_test.go b/azurestack/data_source_network_security_group_test.go
@@ -14,7 +14,7 @@ func TestAccDataSourceAzureStackNetworkSecurityGroup_basic(t *testing.T) {
 	location := testLocation()
 	config := testAccDataSourceAzureStackNetworkSecurityGroupBasic(ri, location)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackNetworkSecurityGroupDestroy,
@@ -37,7 +37,7 @@ func TestAccDataSourceAzureStackNetworkSecurityGroup_rules(t *testing.T) {
 	location := testLocation()
 	config := testAccDataSourceAzureStackNetworkSecurityGroupWithRules(ri, location)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackNetworkSecurityGroupDestroy,
@@ -69,7 +69,7 @@ func TestAccDataSourceAzureStackNetworkSecurityGroup_tags(t *testing.T) {
 	location := testLocation()
 	config := testAccDataSourceAzureStackNetworkSecurityGroupTags(ri, location)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackNetworkSecurityGroupDestroy,

diff --git a/azurestack/data_source_public_ip_test.go b/azurestack/data_source_public_ip_test.go
@@ -17,7 +17,7 @@ func TestAccDataAzureStackPublicIP_basic(t *testing.T) {
 
 	config := testAccDataAzureStackPublicIPBasic(name, resourceGroupName, ri, testLocation())
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackPublicIpDestroy,

diff --git a/azurestack/data_source_resource_group_test.go b/azurestack/data_source_resource_group_test.go
@@ -14,7 +14,7 @@ func TestAccDataSourceAzureStackResourceGroup_basic(t *testing.T) {
 	name := fmt.Sprintf("acctestRg_%d", ri)
 	location := testLocation()
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{

diff --git a/azurestack/data_source_route_table_test.go b/azurestack/data_source_route_table_test.go
@@ -14,7 +14,7 @@ func TestAccDataSourceAzureStackRouteTable_basic(t *testing.T) {
 	location := testLocation()
 	config := testAccDataSourceAzureStackRouteTable_basic(ri, location)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackRouteTableDestroy,
@@ -36,7 +36,7 @@ func TestAccDataSourceAzureStackRouteTable_singleRoute(t *testing.T) {
 	location := testLocation()
 	config := testAccDataSourceAzureStackRouteTable_singleRoute(ri, location)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackRouteTableDestroy,
@@ -61,7 +61,7 @@ func TestAccDataSourceAzureStackRouteTable_multipleRoutes(t *testing.T) {
 	location := testLocation()
 	config := testAccDataSourceAzureStackRouteTable_multipleRoutes(ri, location)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackRouteTableDestroy,

diff --git a/azurestack/data_source_storage_account_test.go b/azurestack/data_source_storage_account_test.go
@@ -16,7 +16,7 @@ func TestAccDataSourceAzureStackStorageAccount_basic(t *testing.T) {
 	preConfig := testAccDataSourceAzureStackStorageAccount_basic(ri, rs, location)
 	config := testAccDataSourceAzureStackStorageAccount_basicWithDataSource(ri, rs, location)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackStorageAccountDestroy,

diff --git a/azurestack/data_source_subnet_test.go b/azurestack/data_source_subnet_test.go
@@ -12,7 +12,7 @@ func TestAccDataSourceArmSubnet_basic(t *testing.T) {
 	resourceName := "data.azurestack_subnet.test"
 	ri := acctest.RandInt()
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{
@@ -35,7 +35,7 @@ func TestAccDataSourceArmSubnet_networkSecurityGroup(t *testing.T) {
 	dataSourceName := "data.azurestack_subnet.test"
 	ri := acctest.RandInt()
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{
@@ -58,7 +58,7 @@ func TestAccDataSourceArmSubnet_routeTable(t *testing.T) {
 	dataSourceName := "data.azurestack_subnet.test"
 	ri := acctest.RandInt()
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{

diff --git a/azurestack/data_source_virtual_network_gateway_test.go b/azurestack/data_source_virtual_network_gateway_test.go
@@ -12,7 +12,7 @@ func TestAccAzureStackDataSourceVirtualNetworkGateway_basic(t *testing.T) {
 	ri := acctest.RandInt()
 	config := testAccAzureStackDataSourceVirtualNetworkGateway_basic(ri, testLocation())
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackVirtualNetworkGatewayDestroy,

diff --git a/azurestack/data_source_virtual_network_test.go b/azurestack/data_source_virtual_network_test.go
@@ -15,7 +15,7 @@ func TestAccDataSourceArmVirtualNetwork_basic(t *testing.T) {
 	name := fmt.Sprintf("acctestvnet-%d", ri)
 	config := testAccDataSourceArmVirtualNetwork_basic(ri, testLocation())
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{
@@ -43,7 +43,7 @@ func TestAccDataSourceArmVirtualNetwork_peering(t *testing.T) {
 	virtualNetworkName := fmt.Sprintf("acctestvnet-1-%d", ri)
 	location := testLocation()
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{

diff --git a/azurestack/resource_arm_availability_set_test.go b/azurestack/resource_arm_availability_set_test.go
@@ -15,7 +15,7 @@ func TestAccAzureStackAvailabilitySet_basic(t *testing.T) {
 	ri := acctest.RandInt()
 	config := testAccAzureStackAvailabilitySet_basic(ri, testLocation())
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackAvailabilitySetDestroy,
@@ -42,7 +42,7 @@ func TestAccAzureStackAvailabilitySet_disappears(t *testing.T) {
 	ri := acctest.RandInt()
 	config := testAccAzureStackAvailabilitySet_basic(ri, testLocation())
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackAvailabilitySetDestroy,
@@ -68,7 +68,7 @@ func TestAccAzureStackAvailabilitySet_withTags(t *testing.T) {
 	preConfig := testAccAzureStackAvailabilitySet_withTags(ri, location)
 	postConfig := testAccAzureStackAvailabilitySet_withUpdatedTags(ri, location)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackAvailabilitySetDestroy,
@@ -104,7 +104,7 @@ func TestAccAzureStackAvailabilitySet_withDomainCounts(t *testing.T) {
 	ri := acctest.RandInt()
 	config := testAccAzureStackAvailabilitySet_withDomainCounts(ri, testLocation())
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackAvailabilitySetDestroy,
@@ -135,7 +135,7 @@ func TestAccAzureStackAvailabilitySet_managed(t *testing.T) {
 	ri := acctest.RandInt()
 	config := testAccAzureStackAvailabilitySet_managed(ri, testLocation())
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackAvailabilitySetDestroy,

diff --git a/azurestack/resource_arm_dns_a_record_test.go b/azurestack/resource_arm_dns_a_record_test.go
@@ -16,7 +16,7 @@ func TestAccAzureStackDnsARecord_basic(t *testing.T) {
 	ri := acctest.RandInt()
 	config := testAccAzureStackDnsARecord_basic(ri, testLocation())
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackDnsARecordDestroy,
@@ -38,7 +38,7 @@ func TestAccAzureStackDnsARecord_updateRecords(t *testing.T) {
 	preConfig := testAccAzureStackDnsARecord_basic(ri, location)
 	postConfig := testAccAzureStackDnsARecord_updateRecords(ri, location)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackDnsARecordDestroy,
@@ -68,7 +68,7 @@ func TestAccAzureStackDnsARecord_withTags(t *testing.T) {
 	preConfig := testAccAzureStackDnsARecord_withTags(ri, location)
 	postConfig := testAccAzureStackDnsARecord_withTagsUpdate(ri, location)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackDnsARecordDestroy,

diff --git a/azurestack/resource_arm_dns_zone_test.go b/azurestack/resource_arm_dns_zone_test.go
@@ -15,7 +15,7 @@ func TestAccAzureStackDnsZone_basic(t *testing.T) {
 	ri := acctest.RandInt()
 	config := testAccAzureStackDnsZone_basic(ri, testLocation())
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackDnsZoneDestroy,
@@ -37,7 +37,7 @@ func TestAccAzureStackDnsZone_withTags(t *testing.T) {
 	preConfig := testAccAzureStackDnsZone_withTags(ri, location)
 	postConfig := testAccAzureStackDnsZone_withTagsUpdate(ri, location)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackDnsZoneDestroy,

diff --git a/azurestack/resource_arm_loadbalancer_backend_address_pool_test.go b/azurestack/resource_arm_loadbalancer_backend_address_pool_test.go
@@ -21,7 +21,7 @@ func TestAccAzureStackLoadBalancerBackEndAddressPool_basic(t *testing.T) {
 		"/subscriptions/%s/resourceGroups/acctestRG-%d/providers/Microsoft.Network/loadBalancers/arm-test-loadbalancer-%d/backendAddressPools/%s",
 		subscriptionID, ri, ri, addressPoolName)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackLoadBalancerDestroy,
@@ -49,7 +49,7 @@ func TestAccAzureStackLoadBalancerBackEndAddressPool_removal(t *testing.T) {
 	ri := acctest.RandInt()
 	addressPoolName := fmt.Sprintf("%d-address-pool", ri)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackLoadBalancerDestroy,
@@ -70,7 +70,7 @@ func TestAccAzureStackLoadBalancerBackEndAddressPool_disappears(t *testing.T) {
 	ri := acctest.RandInt()
 	addressPoolName := fmt.Sprintf("%d-address-pool", ri)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackLoadBalancerDestroy,

diff --git a/azurestack/resource_arm_loadbalancer_nat_pool_test.go b/azurestack/resource_arm_loadbalancer_nat_pool_test.go
@@ -21,7 +21,7 @@ func TestAccAzureStackLoadBalancerNatPool_basic(t *testing.T) {
 		"/subscriptions/%s/resourceGroups/acctestRG-%d/providers/Microsoft.Network/loadBalancers/arm-test-loadbalancer-%d/inboundNatPools/%s",
 		subscriptionID, ri, ri, natPoolName)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackLoadBalancerDestroy,
@@ -49,7 +49,7 @@ func TestAccAzureStackLoadBalancerNatPool_removal(t *testing.T) {
 	ri := acctest.RandInt()
 	natPoolName := fmt.Sprintf("NatPool-%d", ri)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackLoadBalancerDestroy,
@@ -78,7 +78,7 @@ func TestAccAzureStackLoadBalancerNatPool_update(t *testing.T) {
 	natPoolName := fmt.Sprintf("NatPool-%d", ri)
 	natPool2Name := fmt.Sprintf("NatPool-%d", acctest.RandInt())
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackLoadBalancerDestroy,
@@ -110,7 +110,7 @@ func TestAccAzureStackLoadBalancerNatPool_disappears(t *testing.T) {
 	ri := acctest.RandInt()
 	natPoolName := fmt.Sprintf("NatPool-%d", ri)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackLoadBalancerDestroy,

diff --git a/azurestack/resource_arm_loadbalancer_nat_rule_test.go b/azurestack/resource_arm_loadbalancer_nat_rule_test.go
@@ -21,7 +21,7 @@ func TestAccAzureStackLoadBalancerNatRule_basic(t *testing.T) {
 		"/subscriptions/%s/resourceGroups/acctestRG-%d/providers/Microsoft.Network/loadBalancers/arm-test-loadbalancer-%d/inboundNatRules/%s",
 		subscriptionID, ri, ri, natRuleName)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackLoadBalancerDestroy,
@@ -49,7 +49,7 @@ func TestAccAzureStackLoadBalancerNatRule_removal(t *testing.T) {
 	ri := acctest.RandInt()
 	natRuleName := fmt.Sprintf("NatRule-%d", ri)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackLoadBalancerDestroy,
@@ -78,7 +78,7 @@ func TestAccAzureStackLoadBalancerNatRule_update(t *testing.T) {
 	natRuleName := fmt.Sprintf("NatRule-%d", ri)
 	natRule2Name := fmt.Sprintf("NatRule-%d", acctest.RandInt())
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackLoadBalancerDestroy,
@@ -112,7 +112,7 @@ func TestAccAzureStackLoadBalancerNatRule_disappears(t *testing.T) {
 	ri := acctest.RandInt()
 	natRuleName := fmt.Sprintf("NatRule-%d", ri)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackLoadBalancerDestroy,
@@ -136,7 +136,7 @@ func TestAccAzureStackLoadBalancerNatRule_enableFloatingIP(t *testing.T) {
 	natRuleName := fmt.Sprintf("NatRule-%d", ri)
 	location := testLocation()
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackLoadBalancerDestroy,
@@ -158,7 +158,7 @@ func TestAccAzureStackLoadBalancerNatRule_disableFloatingIP(t *testing.T) {
 	natRuleName := fmt.Sprintf("NatRule-%d", ri)
 	location := testLocation()
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testCheckAzureStackLoadBalancerDestroy,