Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Event Grid Domain/Topic system managed identity #9906

Conversation

jrauschenbusch
Copy link
Contributor

Fixes #9525

make acctests SERVICE='eventgrid' TESTARGS='-run=TestAccEventGridTopic_basicWithIdentity' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/eventgrid/tests/ -run=TestAccEventGridTopic_basicWithIdentity -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccEventGridTopic_basicWithIdentity
=== PAUSE TestAccEventGridTopic_basicWithIdentity
=== CONT  TestAccEventGridTopic_basicWithIdentity
--- PASS: TestAccEventGridTopic_basicWithIdentity (116.60s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventgrid/tests     118.483s
make acctests SERVICE='eventgrid' TESTARGS='-run=TestAccEventGridDomain_basicWithIdentity' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/eventgrid/tests/ -run=TestAccEventGridDomain_basicWithIdentity -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccEventGridDomain_basicWithIdentity
=== PAUSE TestAccEventGridDomain_basicWithIdentity
=== CONT  TestAccEventGridDomain_basicWithIdentity
--- PASS: TestAccEventGridDomain_basicWithIdentity (119.35s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventgrid/tests     121.912s

@ghost ghost added size/XXL and removed size/L labels Jan 20, 2021
@jrauschenbusch jrauschenbusch force-pushed the event-grid-topic-system-managed-identity branch from 144c783 to f8aa75c Compare January 20, 2021 10:57
@ghost ghost added size/L and removed size/XXL labels Jan 20, 2021
@jrauschenbusch jrauschenbusch force-pushed the event-grid-topic-system-managed-identity branch from f8aa75c to 9b29549 Compare March 4, 2021 09:32
@tombuildsstuff tombuildsstuff added this to the v2.51.0 milestone Mar 9, 2021
@katbyte katbyte modified the milestones: v2.51.0, v2.52.0 Mar 12, 2021
@jackofallops jackofallops modified the milestones: v2.52.0, v2.53.0 Mar 18, 2021
@jackofallops jackofallops modified the milestones: v2.53.0, v2.54.0 Mar 26, 2021
@katbyte katbyte modified the milestones: v2.54.0, v2.55.0 Apr 2, 2021
@katbyte katbyte modified the milestones: v2.55.0, v2.56.0, v2.57.0 Apr 9, 2021
@hashicorp hashicorp deleted a comment Apr 28, 2021
@katbyte katbyte modified the milestones: v2.59.0, v2.60.0, v2.61.0 May 14, 2021
@tombuildsstuff tombuildsstuff modified the milestones: v2.61.0, v2.62.0 May 27, 2021
@katbyte katbyte modified the milestones: v2.62.0, v2.63.0 Jun 4, 2021
@katbyte katbyte modified the milestones: v2.63.0, v2.64.0 Jun 11, 2021
@katbyte katbyte modified the milestones: v2.64.0, v2.65.0 Jun 18, 2021
@tombuildsstuff tombuildsstuff modified the milestones: v2.65.0, v2.66.0 Jun 25, 2021
@jackofallops jackofallops modified the milestones: v2.66.0, v2.67.0, v2.68.0 Jul 2, 2021
@jackofallops jackofallops modified the milestones: v2.68.0, v2.70.0 Jul 15, 2021
@katbyte katbyte modified the milestones: v2.70.0, v2.71.0 Jul 30, 2021
@katbyte
Copy link
Collaborator

katbyte commented Jul 30, 2021

Hey @jrauschenbusch - as theres been no activity on this since may i'm going to close it. Please do reopen it when you have time to address the comments! thanks

@github-actions
Copy link

github-actions bot commented Aug 6, 2021

This functionality has been released in v2.71.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for System Managed Identity in Event Grid Domain and Event Grid Topic
5 participants