Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loganalytics: removing the superflurous subscriptionId argument from the ID func #9801

Merged
merged 2 commits into from
Dec 10, 2020

Conversation

tombuildsstuff
Copy link
Contributor

This is the last remnant, at which point we can remove this unnecessary argument from the formatter and re-generate

@tombuildsstuff tombuildsstuff added this to the v2.40.0 milestone Dec 10, 2020
@tombuildsstuff tombuildsstuff requested a review from a team December 10, 2020 11:14
@ghost ghost added the size/XS label Dec 10, 2020
@ghost ghost added size/S and removed size/XS labels Dec 10, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

Generation failure has been fixed via #9802 - have re-run this locally and it's fine, but this isn't worth another full test suite run in GHA

@tombuildsstuff tombuildsstuff merged commit 4d51c8a into master Dec 10, 2020
@tombuildsstuff tombuildsstuff deleted the r/resource-ids/subscription-id-cleanup branch December 10, 2020 12:20
@ghost
Copy link

ghost commented Dec 10, 2020

This has been released in version 2.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 9, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants