-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new properties alert_rule_template_guid
and display_name_exclude_filter
for azurerm_sentinel_alert_rule_ms_security_incident
#9797
Conversation
alert_rule_template_name
and display_name_exclude_filter
for azurerm_sentinel_alert_rule_ms_security_incident
website/docs/r/sentinel_alert_rule_ms_security_incident.html.markdown
Outdated
Show resolved
Hide resolved
alert_rule_template_name
and display_name_exclude_filter
for azurerm_sentinel_alert_rule_ms_security_incidentalert_rule_template_guid
and display_name_exclude_filter
for azurerm_sentinel_alert_rule_ms_security_incident
@katbyte , thanks for your comments. I've updated code per your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @neil-yechenwei - this LGTM 👍
This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.42.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
The purpose of this PR is to support below two new properties for
azurerm_sentinel_alert_rule_ms_security_incident
.The first property is
alert_rule_template_guid
. It is the id of the alert rule template which is used to create this Sentinel Scheduled Alert Rule.The second property is
display_name_exclude_filter
. It is used to create incidents when the alert display name doesn't contain text from the specified list.--- PASS: TestAccAzureRMSentinelAlertRuleMsSecurityIncident_basic (165.11s)
--- PASS: TestAccAzureRMSentinelAlertRuleMsSecurityIncident_complete (165.12s)
--- PASS: TestAccAzureRMSentinelAlertRuleMsSecurityIncident_withAlertRuleTemplateName (165.74s)
--- PASS: TestAccAzureRMSentinelAlertRuleMsSecurityIncident_requiresImport (178.59s)
--- PASS: TestAccAzureRMSentinelAlertRuleMsSecurityIncident_withDisplayNameExcludeFilter (300.20s)
--- PASS: TestAccAzureRMSentinelAlertRuleMsSecurityIncident_update (331.34s)
API doc for these two properties:
https://docs.microsoft.com/en-us/rest/api/securityinsights/alertrules/createorupdate#microsoftsecurityincidentcreationalertrule