-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
role_assignment: fix immediate read after write issue #9698
role_assignment: fix immediate read after write issue #9698
Conversation
Azure AD API requests provide inconsistent results. The `Create` API call returns enough information to be used in future read calls and should be used instead of requiring a `Get` API call immediately after. Once we have the ID, we can wait for the state change later and poll until the AD API becomes consistent for the resource just created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the race we've been hitting. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dlamotte - this LGTM 👍
@katbyte 👍 I just merged master in as there was conflicts. |
Hi @dlamotte - Thanks for this PR. I've had to take a look at this issue for another reason and needed to take a different approach to avoid introducing other subtle bugs / issues, as such I'll need to close your PR (since it's part of an Org, not a user, I can't push over the top) and open a new one with my changes. |
@jackofallops I took a look at your PR and it looks good to me. Excited to have it merged. |
This has been released in version 2.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.43.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Azure AD API requests provide inconsistent results. The
Create
APIcall returns enough information to be used in future read calls and
should be used instead of requiring a
Get
API call immediately after.Once we have the ID, we can wait for the state change later and poll
until the AD API becomes consistent for the resource just created.