-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new resource azurerm_scheduler_job_collection #963
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,274 @@ | ||
package azurerm | ||
|
||
import ( | ||
"fmt" | ||
"log" | ||
|
||
"github.com/Azure/azure-sdk-for-go/services/scheduler/mgmt/2016-03-01/scheduler" | ||
|
||
"github.com/hashicorp/terraform/helper/schema" | ||
"github.com/hashicorp/terraform/helper/validation" | ||
"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/response" | ||
"github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils" | ||
) | ||
|
||
func resourceArmSchedulerJobCollection() *schema.Resource { | ||
return &schema.Resource{ | ||
Create: resourceArmSchedulerJobCollectionCreateUpdate, | ||
Read: resourceArmSchedulerJobCollectionRead, | ||
Update: resourceArmSchedulerJobCollectionCreateUpdate, | ||
Delete: resourceArmSchedulerJobCollectionDelete, | ||
|
||
Importer: &schema.ResourceImporter{ | ||
State: schema.ImportStatePassthrough, | ||
}, | ||
|
||
Schema: map[string]*schema.Schema{ | ||
"name": { | ||
Type: schema.TypeString, | ||
Required: true, | ||
ForceNew: true, | ||
}, | ||
|
||
"location": locationSchema(), | ||
|
||
"resource_group_name": resourceGroupNameSchema(), | ||
|
||
"tags": tagsSchema(), | ||
|
||
"sku": { | ||
Type: schema.TypeString, | ||
Required: true, | ||
DiffSuppressFunc: ignoreCaseDiffSuppressFunc, | ||
ValidateFunc: validation.StringInSlice([]string{ | ||
string(scheduler.Free), | ||
string(scheduler.Standard), | ||
string(scheduler.P10Premium), | ||
string(scheduler.P20Premium), | ||
}, true), | ||
}, | ||
|
||
//optional | ||
"state": { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Default: string(scheduler.Enabled), | ||
DiffSuppressFunc: ignoreCaseDiffSuppressFunc, | ||
ValidateFunc: validation.StringInSlice([]string{ | ||
string(scheduler.Enabled), | ||
string(scheduler.Suspended), | ||
string(scheduler.Disabled), | ||
}, true), | ||
}, | ||
|
||
"quota": { | ||
Type: schema.TypeList, | ||
Optional: true, | ||
MaxItems: 1, | ||
Elem: &schema.Resource{ | ||
Schema: map[string]*schema.Schema{ | ||
|
||
//max_job_occurrence doesn't seem to do anything and always remains empty | ||
|
||
"max_job_count": { | ||
Type: schema.TypeInt, | ||
Optional: true, | ||
ValidateFunc: validation.IntAtLeast(0), | ||
}, | ||
|
||
"max_recurrence_frequency": { | ||
Type: schema.TypeString, | ||
Required: true, | ||
DiffSuppressFunc: ignoreCaseDiffSuppressFunc, | ||
ValidateFunc: validation.StringInSlice([]string{ | ||
string(scheduler.Minute), | ||
string(scheduler.Hour), | ||
string(scheduler.Day), | ||
string(scheduler.Week), | ||
string(scheduler.Month), | ||
}, true), | ||
}, | ||
|
||
//this sets MaxRecurrance.Interval, and the documentation in the api states: | ||
// Gets or sets the interval between retries. | ||
"max_retry_interval": { | ||
Type: schema.TypeInt, | ||
Optional: true, | ||
ValidateFunc: validation.IntAtLeast(1), //changes depending on the frequency, unknown maximums | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
} | ||
} | ||
|
||
func resourceArmSchedulerJobCollectionCreateUpdate(d *schema.ResourceData, meta interface{}) error { | ||
client := meta.(*ArmClient).schedulerJobCollectionsClient | ||
ctx := meta.(*ArmClient).StopContext | ||
|
||
name := d.Get("name").(string) | ||
location := d.Get("location").(string) | ||
resourceGroup := d.Get("resource_group_name").(string) | ||
tags := d.Get("tags").(map[string]interface{}) | ||
|
||
log.Printf("[DEBUG] Creating/updating Scheduler Job Collection %q (resource group %q)", name, resourceGroup) | ||
|
||
collection := scheduler.JobCollectionDefinition{ | ||
Location: utils.String(location), | ||
Tags: expandTags(tags), | ||
Properties: &scheduler.JobCollectionProperties{ | ||
Sku: &scheduler.Sku{ | ||
Name: scheduler.SkuDefinition(d.Get("sku").(string)), | ||
}, | ||
}, | ||
} | ||
|
||
if state, ok := d.Get("state").(string); ok { | ||
collection.Properties.State = scheduler.JobCollectionState(state) | ||
} | ||
collection.Properties.Quota = expandAzureArmSchedulerJobCollectionQuota(d) | ||
|
||
//create job collection | ||
collection, err := client.CreateOrUpdate(ctx, resourceGroup, name, collection) | ||
if err != nil { | ||
return fmt.Errorf("Error creating/updating Scheduler Job Collection %q (Resource Group %q): %+v", name, resourceGroup, err) | ||
} | ||
|
||
//ensure collection actually exists and we have the correct ID | ||
collection, err = client.Get(ctx, resourceGroup, name) | ||
if err != nil { | ||
return fmt.Errorf("Error reading Scheduler Job Collection %q after create/update (Resource Group %q): %+v", name, resourceGroup, err) | ||
} | ||
|
||
d.SetId(*collection.ID) | ||
|
||
return resourceArmSchedulerJobCollectionPopulate(d, resourceGroup, &collection) | ||
} | ||
|
||
func resourceArmSchedulerJobCollectionRead(d *schema.ResourceData, meta interface{}) error { | ||
client := meta.(*ArmClient).schedulerJobCollectionsClient | ||
ctx := meta.(*ArmClient).StopContext | ||
|
||
id, err := parseAzureResourceID(d.Id()) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
name := id.Path["jobCollections"] | ||
resourceGroup := id.ResourceGroup | ||
|
||
log.Printf("[DEBUG] Reading Scheduler Job Collection %q (resource group %q)", name, resourceGroup) | ||
|
||
collection, err := client.Get(ctx, resourceGroup, name) | ||
if err != nil { | ||
if utils.ResponseWasNotFound(collection.Response) { | ||
d.SetId("") | ||
return nil | ||
} | ||
|
||
return fmt.Errorf("Error making Read request on Scheduler Job Collection %q (Resource Group %q): %+v", name, resourceGroup, err) | ||
} | ||
|
||
return resourceArmSchedulerJobCollectionPopulate(d, resourceGroup, &collection) | ||
} | ||
|
||
func resourceArmSchedulerJobCollectionPopulate(d *schema.ResourceData, resourceGroup string, collection *scheduler.JobCollectionDefinition) error { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should be able to move this into the Read method? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I separated it out like this so there wouldn't be two read requests after a create/update. |
||
|
||
//standard properties | ||
d.Set("name", collection.Name) | ||
d.Set("location", azureRMNormalizeLocation(*collection.Location)) | ||
d.Set("resource_group_name", resourceGroup) | ||
flattenAndSetTags(d, collection.Tags) | ||
|
||
//resource specific | ||
if properties := collection.Properties; properties != nil { | ||
if sku := properties.Sku; sku != nil { | ||
d.Set("sku", sku.Name) | ||
} | ||
d.Set("state", string(properties.State)) | ||
|
||
if err := d.Set("quota", flattenAzureArmSchedulerJobCollectionQuota(properties.Quota)); err != nil { | ||
return fmt.Errorf("Error flattening quota for Job Collection %q (Resource Group %q): %+v", collection.Name, resourceGroup, err) | ||
} | ||
} | ||
|
||
return nil | ||
} | ||
|
||
func resourceArmSchedulerJobCollectionDelete(d *schema.ResourceData, meta interface{}) error { | ||
client := meta.(*ArmClient).schedulerJobCollectionsClient | ||
ctx := meta.(*ArmClient).StopContext | ||
|
||
id, err := parseAzureResourceID(d.Id()) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
name := id.Path["jobCollections"] | ||
resourceGroup := id.ResourceGroup | ||
|
||
log.Printf("[DEBUG] Deleting Scheduler Job Collection %q (resource group %q)", name, resourceGroup) | ||
|
||
future, err := client.Delete(ctx, resourceGroup, name) | ||
if err != nil { | ||
if !response.WasNotFound(future.Response()) { | ||
return fmt.Errorf("Error issuing delete request for Scheduler Job Collection %q (Resource Group %q): %+v", name, resourceGroup, err) | ||
} | ||
} | ||
|
||
err = future.WaitForCompletion(ctx, client.Client) | ||
if err != nil { | ||
if !response.WasNotFound(future.Response()) { | ||
return fmt.Errorf("Error waiting for deletion of Scheduler Job Collection %q (Resource Group %q): %+v", name, resourceGroup, err) | ||
} | ||
} | ||
|
||
return nil | ||
} | ||
|
||
func expandAzureArmSchedulerJobCollectionQuota(d *schema.ResourceData) *scheduler.JobCollectionQuota { | ||
if qb, ok := d.Get("quota").([]interface{}); ok && len(qb) > 0 { | ||
quota := scheduler.JobCollectionQuota{ | ||
MaxRecurrence: &scheduler.JobMaxRecurrence{}, | ||
} | ||
|
||
quotaBlock := qb[0].(map[string]interface{}) | ||
|
||
if v, ok := quotaBlock["max_job_count"].(int); ok { | ||
quota.MaxJobCount = utils.Int32(int32(v)) | ||
} | ||
if v, ok := quotaBlock["max_recurrence_frequency"].(string); ok { | ||
quota.MaxRecurrence.Frequency = scheduler.RecurrenceFrequency(v) | ||
} | ||
if v, ok := quotaBlock["max_retry_interval"].(int); ok { | ||
quota.MaxRecurrence.Interval = utils.Int32(int32(v)) | ||
} | ||
|
||
return "a | ||
} | ||
|
||
return nil | ||
} | ||
|
||
func flattenAzureArmSchedulerJobCollectionQuota(quota *scheduler.JobCollectionQuota) []interface{} { | ||
|
||
if quota == nil { | ||
return nil | ||
} | ||
|
||
quotaBlock := make(map[string]interface{}) | ||
|
||
if v := quota.MaxJobCount; v != nil { | ||
quotaBlock["max_job_count"] = *v | ||
} | ||
if recurrence := quota.MaxRecurrence; recurrence != nil { | ||
if v := recurrence.Interval; v != nil { | ||
quotaBlock["max_retry_interval"] = *v | ||
} | ||
|
||
quotaBlock["max_recurrence_frequency"] = string(recurrence.Frequency) | ||
} | ||
|
||
return []interface{}{quotaBlock} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that I guess this field is deprecated (or the API’s broken) - so we can ignore it for now 👍